Skip to content

test: replace expired self-signed SSL certificates in tests - #34676

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:test/update-expired-ssl-certs
Nov 9, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:test/update-expired-ssl-certs

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Replaces expired self-signed SSL certificates in unit and E2E tests with the 100-year valid CN=localhost certificate already used in ssl_spec.ts (valid until 2126).

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 9, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 9, 2026
@alan-agius4
alan-agius4 merged commit 5844a54 into angular:main Nov 9, 2026
41 checks passed
@alan-agius4
alan-agius4 deleted the test/update-expired-ssl-certs branch November 9, 2026 09:29
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mock SSL certificates and private keys across several dev-server test files, replacing the older RSA-based credentials with Elliptic Curve (EC) ones. The review feedback correctly points out that the newly added self-signed certificate has a validity start date in the future (October 2026), which could lead to latent test failures in environments with strict SSL validation, and recommends regenerating the certificate with a start date in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants